Add a Custom Parameter button that adds a Command Line Argument ConfigItem into the list.#286
Add a Custom Parameter button that adds a Command Line Argument ConfigItem into the list.#286VelonacepsCalyxEggs wants to merge 4 commits intoruarai:masterfrom
Conversation
…gument ConfigItem into the list. Not sure if the implementation is good, it always assumes the Command Line Argument is the last in the list, I don't have enough codebase knowledge to know if it is always the case, if it is not, using LINQ could be a solution. Some people are confused searching for adding a custom parameter into the executable, I felt the same.
|
I like the idea, but you shouldn't assume its always last in the list. Some processes like Pack don't even allow custom command line arguments |
I agree, I thought that might be an issue. Maybe disabling the button when there is no Custom Argument ConfigItem in the list for a selected executable would be fine? |
|
Yea, or just hiding it |
…rgument ConfigItem.
|
Decided to just disable the button instead of hiding it, looked kinda awkward with the extra empty space. |
Some people are confused searching for adding a custom parameter into the executable, I felt the same.
Not sure if the implementation is good, it always assumes the Command Line Argument is always the last in the list, I don't have enough codebase knowledge to know if it is always the case, but in case it's not, maybe using LINQ to find one could be okay.