Skip to content

Add a Custom Parameter button that adds a Command Line Argument ConfigItem into the list.#286

Open
VelonacepsCalyxEggs wants to merge 4 commits intoruarai:masterfrom
VelonacepsCalyxEggs:cmdargbutton
Open

Add a Custom Parameter button that adds a Command Line Argument ConfigItem into the list.#286
VelonacepsCalyxEggs wants to merge 4 commits intoruarai:masterfrom
VelonacepsCalyxEggs:cmdargbutton

Conversation

@VelonacepsCalyxEggs
Copy link

Some people are confused searching for adding a custom parameter into the executable, I felt the same.

Not sure if the implementation is good, it always assumes the Command Line Argument is always the last in the list, I don't have enough codebase knowledge to know if it is always the case, but in case it's not, maybe using LINQ to find one could be okay.

…gument ConfigItem into the list.

Not sure if the implementation is good, it always assumes the Command Line Argument is the last in the list, I don't have enough codebase knowledge to know if it is always the case, if it is not, using LINQ could be a solution.

Some people are confused searching for adding a custom parameter into the executable, I felt the same.
@Exactol
Copy link
Collaborator

Exactol commented Feb 1, 2026

I like the idea, but you shouldn't assume its always last in the list. Some processes like Pack don't even allow custom command line arguments

@VelonacepsCalyxEggs
Copy link
Author

I like the idea, but you shouldn't assume its always last in the list. Some processes like Pack don't even allow custom command line arguments

I agree, I thought that might be an issue. Maybe disabling the button when there is no Custom Argument ConfigItem in the list for a selected executable would be fine?

@Exactol
Copy link
Collaborator

Exactol commented Feb 1, 2026

Yea, or just hiding it

@VelonacepsCalyxEggs
Copy link
Author

Decided to just disable the button instead of hiding it, looked kinda awkward with the extra empty space.
Now it checks if the ConfigItem exists during the button press and during UpdateConfigGrid().
I tested it, and it seems to work fine, executable with no Command Line Argument disables the button, and vice-versa.
Had to add a custom one to test though, as all executables seem to have one, even Pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants