fix(windows): improve native build support and Git Bash integration#385
Closed
tobitege wants to merge 11 commits intortk-ai:developfrom
Closed
fix(windows): improve native build support and Git Bash integration#385tobitege wants to merge 11 commits intortk-ai:developfrom
tobitege wants to merge 11 commits intortk-ai:developfrom
Conversation
Fix native Windows startup by setting the MSVC linker stack size in .cargo/config.toml. Add CLI smoke tests and Git Bash integration tests for the built rtk binary. Document the Windows install and usage story in README.md, INSTALL.md, and WINDOWS.md. Add PowerShell helper scripts for local install and installation verification. Ignore potential local .history directory in .gitignore. Signed-off-by: tobitege <10787084+tobitege@users.noreply.github.com>
sync dev
add security check cicd on dev branch PR Signed-off-by: aesoft <43991222+aeppling@users.noreply.github.com>
fix(cicd): Add security check on dev branch PR
- Add install_method detection (homebrew/cargo/script/nix/other) - Add tokens_saved_24h and tokens_saved_total to payload - Add Tracker::total_tokens_saved() and Tracker::tokens_saved_24h() methods - Point telemetry to new dedicated rtk-telemetry service Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
# Conflicts: # README.md
Author
|
Conflict resolved. |
pszymkowiak
force-pushed
the
develop
branch
4 times, most recently
from
dc20fc4 to
cc93afc
Compare
Author
|
Thanks @pszymkowiak - I've fixed the interim 2 file conflicts |
Keep the Windows-native branch buildable after refreshing from develop by restoring the missing truncate import in cargo_cmd.rs and relaxing the git command test to accept the absolute Git for Windows path returned on native Windows. Make the Git Bash smoke suite reliable on Windows by copying the RTK binary out of target before self-hosting cargo commands, and by skipping learn/discover and hook version assertions when local Claude Code project state or hook installation is not present. Also update the built-in filter fixtures so empty-input expectations match their configured on_empty output, which makes rtk verify pass again during local validation. Signed-off-by: tobitege <10787084+tobitege@users.noreply.github.com>
Author
|
Tests fixed in my branch and build is fine. |
Signed-off-by: tobitege <10787084+tobitege@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
I hope this is of use for you, should make build+installation on Windows work better and provide some alternatives to linux tools. Most well explained in the new
WINDOWS.md.Summary
This PR improves the native Windows story for RTK and makes the documented Windows support match what actually works in practice.
The main functional fix is a Windows-specific build configuration change so the native
rtk.exeno longer crashes with a stack overflow on startup. On top of that, this PR adds automated CLI coverage for the core tools, adds Git Bash integration coverage on Windows, and documents the difference between "the RTK binary works on Windows" and "some helper scripts and hook-based setup are still Unix-first."What changed
.cargo/config.tomlso native Windows builds start correctlyrtk --versionrtk ls .rtk read Cargo.tomlrtk rewrite "git status"rtk init --showrtk.exeruns inside Git Bashrtkworks from Git Bash viaPATHscripts/check-installation.shworks in Git Bash against the built binaryscripts/install-local.ps1scripts/check-installation.ps1README.md,INSTALL.md, andWINDOWS.md.historyto.gitignoreWhy this matters
Before this change, the repo claimed Windows support in some places, but the real user experience was unclear and incomplete. The core binary was intended to work on Windows, but the install and script story was heavily Unix-oriented, and the Windows binary itself could fail immediately at startup.
This PR makes native Windows support more real and more understandable:
Verification
Verified locally on native Windows with:
cargo buildcargo build --releasecargo test --test cli_tools_smokecargo test --test git_bash_integrationAlso verified:
.\target\debug\rtk.exe --version.\target\debug\rtk.exe ls ..\target\release\rtk.exe --version.\target\release\rtk.exe ls .Notes
This PR does not attempt to fully port every Bash script or the hook-first global setup to native Windows. It focuses on the core CLI, practical local Windows workflows, Git Bash compatibility, and documentation clarity.