Conversation
* test/hyrolo-tests.el (hyrolo-tests--fgrep-move-test): Add more tests for movement when a section is hidden.
rswgnu
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add more hyrolo movement tests.
for movement when a section is hidden.
Why
Adding more movement cases.
One error case is added so the test is marked as expected failed. On
moving up using {b} from the first line gives an error message
(void-function nil) which seems wrong. Should be an error message such
as for {f} moving down or just don't move and not error as is the case
for {n} and {p}.
The test is designed to work when that error is changed but should be
checking the proper error message is shown of course when it is
finalized.