Skip to content

Add hyrolo test case for moving in fgrep result#932

Merged
rswgnu merged 1 commit intomasterfrom
pr_add_hyrolo_bug_test
Apr 9, 2026
Merged

Add hyrolo test case for moving in fgrep result#932
rswgnu merged 1 commit intomasterfrom
pr_add_hyrolo_bug_test

Conversation

@matsl
Copy link
Copy Markdown
Collaborator

@matsl matsl commented Apr 8, 2026

What

Add hyrolo test case for moving in fgrep result.

  • test/hyrolo-tests.el (hyrolo-tests--fgrep-move-test): Add test case
    for moving in HyRolo buffer after fgrep search. Test is set as
    expected failed since there is a problem with moving over hidden
    sections.

Why

More tests and shows a possible bug.

* test/hyrolo-tests.el (hyrolo-tests--fgrep-move-test): Add test case
for moving in *HyRolo* buffer after fgrep search. Test is set as
expected failed since there is a problem with moving over hidden
sections.
@matsl matsl requested a review from rswgnu April 8, 2026 17:52
@rswgnu
Copy link
Copy Markdown
Owner

rswgnu commented Apr 9, 2026

@matsl Why don't you put the tests that fail at the beginning of the test sequence so when edebugging you don't have to step through all the known good tests to see one that is failing.

@rswgnu
Copy link
Copy Markdown
Owner

rswgnu commented Apr 9, 2026

@matsl The HyRolo display buffer now contains text-properties to speed movement. You can no longer manually add text to build such buffers. You must find a start-end region in the source buffer and call hyrolo-add-match to add it to the HyRolo buffer to construct it correctly. Try updating your code and then running tests.

SORRY, I misread your code. I see you do use hyrolo-fgrep to construct the HyRolo display buffer so let me have a deeper look of why it doesn't seem to have the right text properties in it.

@rswgnu
Copy link
Copy Markdown
Owner

rswgnu commented Apr 9, 2026

I found the movement problem. I'll deploy your PR, remove the expected fail, apply my movement fix and then push to master with your test working.

@rswgnu rswgnu merged commit 39053a3 into master Apr 9, 2026
4 checks passed
@matsl
Copy link
Copy Markdown
Collaborator Author

matsl commented Apr 9, 2026

Why don't you put the tests that fail at the beginning of the test sequence so when edebugging you don't have to step through all the known good tests to see one that is failing.

When debugging I just comment out the test that works so only the failing test is remaining. It works quite well when using ert-info to wrap each test so it is easy to comment out.

I think it is good to have a set of working tests that sort of proves that the test setup is doing the right thing. An alternative could be to add the failing test as a separate ert-test that we later merge with the ert-test with the good test cases!? That would make it possible to have more than one failing test. WDYT?

@matsl matsl deleted the pr_add_hyrolo_bug_test branch April 9, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants