Bump helm-unittest to v1.1.0, fix errorPattern regexes#885
Merged
Conversation
Helm 3.18.5 changed its JSON schema parser, producing a different
error string format for schema validation failures. helm-unittest
v1.0.1 documented this as a known breaking change.
The posit-chronicle configmap_fail_test.yaml tests used errorPattern
values that matched the old format ("ServiceLogLevel: Does not match
pattern") but not the new one ("'/config/Logging/ServiceLogLevel':
'INVALID' does not match pattern"). This caused the tests to fail
locally with helm-unittest >= v1.0.1 while CI (pinned to v1.0.0)
continued to pass — a latent break waiting for the version bump.
Relax both patterns to ".*ServiceLogLevel.*does not match pattern.*"
and ".*ServiceLogFormat.*does not match pattern.*", which match both
the old and new error formats.
bschwedler
requested review from
a team,
markrtucker,
matt-urbina and
t-margheim
as code owners
Go regex is case-sensitive by default. The old Helm schema error format uses uppercase 'Does not match pattern'; the new format uses lowercase. Add (?i) to both patterns so they match either wording.
t-margheim
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #884.
Helm 3.18.5 changed its JSON schema parser, producing a different error string for schema validation failures. The helm-unittest v1.0.1 release notes documented this as a known breaking change that could cause test failures.
The
posit-chronicleconfigmap_fail_test.yamltests haderrorPatternvalues that matched the old format but not the new one. This caused silent failure: tests passed in CI (pinned to v1.0.0) while failing locally with helm-unittest >= v1.0.1 — a latent break waiting for the version bump.helm-unittestin CI fromv1.0.0tov1.1.0errorPatternregexes to match both old and new error formats:.*ServiceLogLevel.*does not match pattern.*All 68
posit-chronicletests pass locally with v1.0.3 (the version that exposed the break).