fix(workbench): correct job.tpl to check suppressStdinAnnotation#862
Open
bguenn2s wants to merge 2 commits into
Open
fix(workbench): correct job.tpl to check suppressStdinAnnotation#862bguenn2s wants to merge 2 commits into
bguenn2s wants to merge 2 commits into
Conversation
|
|
Contributor
|
@mrinaljoshi @dmortondev Can you please look at this from a launcher job template perspective? |
bguenn2s
force-pushed
the
fix/suppress-stdin-annotation
branch
from
b0e8edb to
33f5b76
Compare
bguenn2s
force-pushed
the
fix/suppress-stdin-annotation
branch
from
33f5b76 to
1741cf3
Compare
Author
|
@ianpittwood @mrinaljoshi PR rebased |
…ead of limitStdinAnnotation In PR rstudio#842, the values.yaml key was renamed from limitStdinAnnotation to suppressStdinAnnotation during review, but the corresponding condition in job.tpl was not updated to match. As a result, the guard always evaluates the wrong key and the stdin annotation is written unconditionally, regardless of the configured value.
bguenn2s
force-pushed
the
fix/suppress-stdin-annotation
branch
from
1741cf3 to
18698d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #842 where the values.yaml key was
renamed from
limitStdinAnnotationtosuppressStdinAnnotationduringreview, but the condition in
job.tplwas not updated to match.As a result,
suppressStdinAnnotation: truehas no effect — the stdinannotation is always written regardless of the configured value.
Changes
charts/rstudio-workbench/files/job.tpl— update condition to checksuppressStdinAnnotationinstead oflimitStdinAnnotationFixes #861