Fix: Fix icon spacing and snapshot formatting#1290
Merged
elnelson575 merged 4 commits intomainfrom Feb 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates toolbar test snapshots to match the minified HTML output format introduced in shiny 1.12.1.9000.
Background
Shiny PR #4350 added .noWS parameters to actionButton() and actionLink() to fix an underline rendering bug. This change removes whitespace from the HTML output, producing HTML without whitespace instead of pretty-printed multi-line format.
Since toolbar_input_button() calls shiny::actionButton() internally, it inherits this no-WS HTML behavior. While this doesn't make much of a difference in shiny::actionButton()'s appearance, toolbar buttons include the tooltip wrapper, which has a larger surrounding html wrapper, so the block of html that is compacted is larger.
Additionally, the noWS inheritance seems to have caused icons in icon-only buttons to shift because how it interacts with flex containers and empty spans. Additional CSS rules were added to prevent this from being a problem in the future by not explicitly setting margins and flex vs. relying on inheritence.
Changes
Updates tests/testthat/_snaps/toolbar.md with de-WS'd HTML format (no other changes to HTML observed)
Updates icon SCSS to realign icons in icon-only buttons after Shiny updates caused them to float off to the side.