Skip to content

use functions from brand.yml package#1288

Merged
gadenbuie merged 3 commits intorstudio:mainfrom
bowerth:main
Feb 24, 2026
Merged

use functions from brand.yml package#1288
gadenbuie merged 3 commits intorstudio:mainfrom
bowerth:main

Conversation

@bowerth
Copy link
Contributor

@bowerth bowerth commented Feb 23, 2026

use has_brand and brand_pluck from brand.yml package

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the brand.yml Shiny example to rely on the public API from the {brand.yml} package instead of bslib’s internal helpers, improving long-term compatibility as internals change.

Changes:

  • Add an explicit {brand.yml} install check and attach the package in the example app.
  • Replace bslib::: internal brand_* helper calls with brand.yml::brand_has() / brand.yml::brand_pluck().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can drop the brand.yml:: prefix (it's clear where brand_pluck() comes from). Can you also please add an entry in NEWS.md?

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gadenbuie gadenbuie merged commit c63aea0 into rstudio:main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants