use functions from brand.yml package#1288
Merged
gadenbuie merged 3 commits intorstudio:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the brand.yml Shiny example to rely on the public API from the {brand.yml} package instead of bslib’s internal helpers, improving long-term compatibility as internals change.
Changes:
- Add an explicit
{brand.yml}install check and attach the package in the example app. - Replace
bslib:::internalbrand_*helper calls withbrand.yml::brand_has()/brand.yml::brand_pluck().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gadenbuie
reviewed
Feb 23, 2026
Member
gadenbuie
left a comment
There was a problem hiding this comment.
Thanks! I think we can drop the brand.yml:: prefix (it's clear where brand_pluck() comes from). Can you also please add an entry in NEWS.md?
gadenbuie
reviewed
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use has_brand and brand_pluck from brand.yml package