Respond to plotly's persistent selection mode #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Feb 9, 2018
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Looks great! I don't have a thought about the color.
Contributor
Author
|
Cool, thanks! BTW, adding color can be useful for making comparisons, so I would say we should add it at some point, but I might not have the time for it in the near future, want me to raise an issue?
|
Contributor
|
I think it is a very cool idea, although I definitely don't have time, either :) |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to perform persistent selection with plotly (similar to how rstudio/leaflet#346 does for leaflet).
It would be ideal to have rows somehow reflect plotly's selection color, let me know if have any ideas how best to go about that (e.g. color the text or highlight the row?)