Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"preview": "rspack preview"
},
"devDependencies": {
"@rspack/cli": "2.0.0-beta.5",
"@rspack/core": "2.0.0-beta.5",
"@rspack/cli": "2.0.0-beta.6",
"@rspack/core": "2.0.0-beta.6",
"@rspack/dev-server": "workspace:*"
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@biomejs/biome": "^1.9.4",
"@hono/node-server": "^1.19.11",
"@rslib/core": "^0.20.0",
"@rspack/core": "2.0.0-beta.5",
"@rspack/core": "2.0.0-beta.6",
"@rspack/plugin-react-refresh": "1.6.1",
"@rstest/core": "^0.9.2",
"@types/mime-types": "3.0.1",
Expand Down
148 changes: 14 additions & 134 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/config.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { DevServerOpenOptions } from '@rspack/core';
import type {
ClientConfiguration,
ConnectHistoryApiFallbackOptions,
DevServer,
NormalizedStatic,
Open,
ServerConfiguration,
WatchFiles,
WebSocketServerConfiguration,
Expand All @@ -15,7 +15,7 @@ export interface ResolvedDevServer extends DevServer {
devMiddleware: DevServer['devMiddleware'];
hot: boolean | 'only';
host?: string;
open: Open[];
open: DevServerOpenOptions[];
magicHtml: boolean;
liveReload: boolean;
webSocketServer: false | WebSocketServerConfiguration;
Expand Down
3 changes: 1 addition & 2 deletions src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ import type {
NormalizedStatic,
Open,
OpenApp,
OpenOptions,
OverlayMessageOptions,
Port,
ProxyConfigArray,
Expand Down Expand Up @@ -1069,7 +1068,7 @@ class Server<
? ([
{
target: '<url>',
options: defaultOpenOptions as OpenOptions,
options: defaultOpenOptions,
},
] as NormalizedOpen[])
: [];
Expand Down
13 changes: 2 additions & 11 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type {
ServerResponse,
} from 'node:http';
import type { ServerOptions } from 'node:https';
import type { DevServerOpenOptions } from '@rspack/core';
import type { FSWatcher, ChokidarOptions as WatchOptions } from 'chokidar';
import type { Options as ConnectHistoryApiFallbackOptions } from 'connect-history-api-fallback';
import type {
Expand Down Expand Up @@ -168,7 +169,7 @@ export interface Open {

export interface NormalizedOpen {
target: string;
options: OpenOptions;
options: DevServerOpenOptions;
}

export interface WebSocketURL {
Expand Down Expand Up @@ -226,13 +227,3 @@ function useFn(
export type BasicApplication = {
use: typeof useFn;
};

// Type definition matching open package's Options type
// (Cannot import directly from ES module in CommonJS context)
export type OpenOptions = {
readonly wait?: boolean;
readonly background?: boolean;
readonly newInstance?: boolean;
readonly app?: OpenApp | readonly OpenApp[];
readonly allowNonzeroExitCode?: boolean;
};
Loading