Conversation
Summary of ChangesHello @SoonIter, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the project's code quality and consistency by implementing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great addition, introducing automated spell checking with cspell which immediately found and fixed a typo. The configuration for cspell is well-structured.
However, there is a significant concern with how the typo was fixed. The change was made directly in a bundled JavaScript file, which is a build artifact. This is not a sustainable practice as the change will be lost the next time the project is built. My review includes a comment with a recommendation on how to address this properly, either by fixing the source file or by patching the dependency if the error is external.
Add cspell to the project for automated spell checking, modeled after the rspress repository configuration. Includes a custom dictionary for project-specific terms and integrates into the lint script and CI.
The typo `extraDescripton` originates from the commander dependency and was incorrectly fixed directly in the bundled output. Revert the bundled file change and add `skills/**/scripts` to cspell ignorePaths since these are build artifacts that should not be spell-checked.
Summary
cspell.config.cjs) modeled after the rspress repositoryscripts/dictionary.txt) with project-specific terms (rstack ecosystem, debugging tools, etc.)cspellandcspell-ban-wordsas dev dependenciescheck-spellinto thelintscript so CI automatically checks spellingDescripton→Description)Test plan
pnpm cspellpasses with 0 issues across 35 files