refactor: compose.yaml example
#54
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been staged into two separate commits assuming the ENV flexibility paired with
unbound.confembedding into thecompose.yamlis undesired. This was based off discussion on a related PR that was focused on dropping the explicit network.Changes:
volumesdnssetting instead of the Rspamddnssetting, as no difference for application specific (Rspamd) DNS config has been identified.net.core.somaxconn=4096for redis has been dropped, given that this workaround is for pre-2020 environments, the 5.4 LTS kernel (Nov 2019 release) that defaults to4096will be EOL in Dec 2025.services.rspamd.portswas dropped due to limited context of their value in publishing, it may be better suited to the README.unbound-networksubnet from containers on other Compose projects. Including the web UI through a common reverse proxy container. Let those.127.0.0.1binding, but AFAIK rspamd already has protection in place to not trust public IPs (and has no issue with default trust to all private range IPs in the config it ships with), so again if this is of value I'd defer to it to an addition in the README.192.0.2.0/24is fine, but since the existing example already seemed focused on flexible configuration, I've unified the IP assignment and subnet definition to ENV vars with defaults. Prior to this theunbound.confwas hard-coded (and built into a custom image), now it leverages Docker Compose feature to be adjusted in sync with usage else where in thecompose.yamlto adjust.use-syslog: noaslogfile: ""already disables syslog, alternativelyuse-syslog: nocould be kept instead, the affect of logs then being defaulted to stdout/stderr might be less obvious though?