Fix exception slicing error when converting exception to exception_wrapper

Summary:
Passing the const& of an exception to the exception_wrapper causes slicing error, if the error is extending std::runtime_error.
Which was the case for this bug.

So, creating an exception_ptr and providing that along with the pure object solves the issue.

Reviewed By: William-J-Earl

Differential Revision: D9829021

fbshipit-source-id: 257d457f9ccf500fa7a15b20d2eb5f2c999bea3a

Author: Fuat Geleri

rsocket/test/transport/TcpDuplexConnectionTest.cpp

@@ -15,6 +15,7 @@
 #include <folly/futures/Future.h>
 #include <folly/io/async/AsyncTransport.h>
 #include <folly/io/async/ScopedEventBaseThread.h>
+#include <folly/io/async/ssl/SSLErrors.h>
 #include <gtest/gtest.h>
 
 #include "rsocket/test/transport/DuplexConnectionTest.h"
@@ -109,5 +110,25 @@ TEST(TcpDuplexConnection, ConnectionAndSubscribersAreUntied) {
       worker.getEventBase());
 }
 
+TEST(TcpDuplexConnection, ExceptionWrapperTest) {
+  folly::AsyncSocketException socketException(
+      folly::AsyncSocketException::AsyncSocketExceptionType::INVALID_STATE,
+      "test",
+      10);
+  folly::SSLException sslException(5, 10, 15, 20);
+
+  const folly::AsyncSocketException& socketExceptionRef = sslException;
+
+  folly::exception_wrapper ex1(socketException);
+  folly::exception_wrapper ex2(sslException);
+
+  // Slicing error:
+  // folly::exception_wrapper ex3(socketExceptionRef);
+
+  // Fixed version:
+  folly::exception_wrapper ex3(
+      std::make_exception_ptr(socketExceptionRef), socketExceptionRef);
+}
+
 } // namespace tests
 } // namespace rsocket

rsocket/transports/tcp/TcpDuplexConnection.cpp

@@ -110,7 +110,7 @@ class TcpReaderWriter : public folly::AsyncTransportWrapper::WriteCallback,
   void writeErr(
       size_t,
       const folly::AsyncSocketException& exn) noexcept override {
-    closeErr(folly::exception_wrapper{exn});
+    closeErr(folly::exception_wrapper{std::make_exception_ptr(exn), exn});
     intrusive_ptr_release(this);
   }
 
@@ -135,7 +135,7 @@ class TcpReaderWriter : public folly::AsyncTransportWrapper::WriteCallback,
   }
 
   void readErr(const folly::AsyncSocketException& exn) noexcept override {
-    closeErr(exn);
+    closeErr(folly::exception_wrapper{std::make_exception_ptr(exn), exn});
     intrusive_ptr_release(this);
   }