fix build with ASSERT undefined

Summary: `tp2/double-conversion` leaks `ASSERT` macro that people confuse and use in their tests. D9696915 fixes it by name-spacing it. This fixes dipper build.

Reviewed By: phoad, pixelb

Differential Revision: D9731952

fbshipit-source-id: f745be9a497b0ff04592c1af9ae383ac6d433c64

Author: Igor Sugak

rsocket/test/RequestChannelTest.cpp

@@ -130,7 +130,7 @@ TEST(RequestChannelTest, RequestOnDisconnectedClient) {
       });
 
   wait_for_on_error.timed_wait(std::chrono::milliseconds(100));
-  ASSERT(did_call_on_error);
+  ASSERT_TRUE(did_call_on_error);
 }
 
 class TestChannelResponder : public rsocket::RSocketResponder {

rsocket/test/RequestResponseTest.cpp

@@ -169,7 +169,7 @@ TEST(RequestResponseTest, RequestOnDisconnectedClient) {
           });
 
   wait_for_on_error.timed_wait(std::chrono::milliseconds(100));
-  ASSERT(did_call_on_error);
+  ASSERT_TRUE(did_call_on_error);
 }
 
 // TODO: test that multiple requests on a requestResponse

rsocket/test/RequestStreamTest.cpp

@@ -177,7 +177,7 @@ TEST(RequestStreamTest, RequestOnDisconnectedClient) {
           });
 
   wait_for_on_error.timed_wait(std::chrono::milliseconds(100));
-  ASSERT(did_call_on_error);
+  ASSERT_TRUE(did_call_on_error);
 }
 
 class TestHandlerResponder : public rsocket::RSocketResponder {