Open
Conversation
Author
|
Inter Black after |
Author
|
Inter Display Black after |
* smallcap addition * version bump * debug sub table * version update
* ss09 buggy changes (duplicated ss entries on ss09) * creating all smallcaps instances (#1) * smallcap addition * version bump * debug sub table * version update * ss09 swiss style and curly l (for own use)
rsms
requested changes
Nov 15, 2024
Owner
rsms
left a comment
rsms
left a comment
There was a problem hiding this comment.
The source has drifted too far away for merging. I even attempted to manually resolve the many merge conflicts, but it would take a very long time to QA.
The easiest path forward is to
- check out the current Inter source
- in Glyphs.app, copy your improved shapes over into & replace /uni1DE7 in Inter-Roman & -Italic Glyphs.app documents
- create a new branch with those changes and submit a new PR (or if you want to be advanced: apply a git reset commit to your current branch and then on top of that the new changes, but this would requires some advanced git-fu)
Also if you don't want to, I can do it (but then you won't be on the record as a contributor)
Author
Thanks. I’ll spend the weekend reviewing possibilities of merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix U+1DE7 curve problem for both Display and Text Black