Skip to content

chore: add mime type checking on post #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rslangl merged 1 commit into from
Apr 30, 2026
Merged

chore: add mime type checking on post #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion internal/api/impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@ import (
"encoding/json"
"fmt"
"io"
"slices"
"net/http"
openapi_types "github.com/oapi-codegen/runtime/types"

"artifacts/internal/storage"
"artifacts/internal/storage/storage_error"
)

var chartMIMEType = []string{"application/gzip"}

type Server struct{
storageHandler storage.Storage
}
Expand Down Expand Up @@ -88,6 +91,14 @@ func (s Server) AddChart(w http.ResponseWriter, r *http.Request) {

// Extract chart name from form data
name := r.FormValue("name")
if name == "" {
w.WriteHeader(http.StatusBadRequest)
_ = json.NewEncoder(w).Encode(Error{
Code: new(int(http.StatusBadRequest)),
Message: new(string("Missing 'name' parameter")),
})
return
}

// Extract chart bytes from form data
f, fh, err := r.FormFile("chart")
Expand All @@ -101,7 +112,15 @@ func (s Server) AddChart(w http.ResponseWriter, r *http.Request) {
}
defer f.Close()

// TODO: validate file type is .tgz
// Reject unsupported MIME type
if eq := slices.Compare(fh.Header["Content-Type"], chartMIMEType); eq != 0 {
w.WriteHeader(http.StatusUnsupportedMediaType)
_ = json.NewEncoder(w).Encode(Error{
Code: new(int(http.StatusUnsupportedMediaType)),
Message: new(string(fmt.Sprintf("Unsupported type: %v", fh.Header["Content-Type"]))),
})
return
}

data, err := io.ReadAll(f)
if err != nil {
Expand Down