Drop stale describe_synonym comment#283
Merged
yahonda merged 1 commit intorsim:masterfrom May 5, 2026
Merged
Conversation
Both lines of the comment above PLSQL::Connection#describe_synonym are no longer true: - "all_synonyms view is quite slow" — measured against Oracle 23ai with a 1500-synonym fixture this method is ~0.43 ms/call, dominated by network round-trip rather than the dictionary-view query. The slow case the comment was written for (oracle-enhanced #2686 saw 29x on private synonyms in a 1000-object schema) doesn't show up at the scales ruby-plsql actually exercises. - "overridden in OCI connection with faster native OCI method" — that override was removed in 4d1f656 (2018, "Remove OCI8#describe_synonym to follow up rsim#153") because the predecessor commit 1daa6ce already deleted its body and made it call super. There is no longer any driver-specific override. The method's name and SQL are self-explanatory; removing both lines without a replacement keeps the file accurate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both lines of the comment above
PLSQL::Connection#describe_synonym(lib/plsql/connection.rb:182-183) are no longer accurate:DBMS_UTILITY.NAME_RESOLVE-based replacement (mirroring Resolve describe() via DBMS_UTILITY.NAME_RESOLVE oracle-enhanced#2686) measured the same ~0.43 ms/call on the same fixture, confirming the catalog query isn't the bottleneck at ruby-plsql's typical scales. The slow case the original comment was written for (oracle-enhanced#2686 saw 29x on private synonyms in a 1000-object schema) doesn't show up here.4d1f656(Feb 2018, "RemoveOCI8#describe_synonymto follow up Avoid usingOCI8#describe_synonymto use the same code #153"), and the preceding commit1daa6cehad already emptied the body to justsuper. There is no driver-specific override today.The method's name and SQL are self-explanatory; removing both lines without a replacement keeps the file accurate.
Test plan
🤖 Generated with Claude Code