Open
Conversation
|
Not repo owner, but question -- karma.conf.js, line 20 you changed the location of jQuery instead of removing. I'm unfamiliar with karma -- does it need jQuery to run, or was the removal by accident? |
Author
|
Jquery isn't a dependency of Karma, but it can be useful for pulling objects from the dom for tests among other things. I updated the reference in the karma config because it was broken, but the angular-tooltip doesn't require it. |
|
Ah, that makes sense. This repo needs a little love so I forked you! Thanks for explaining that 😄 |
Author
|
:) Not a problem! Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's good to remove this dependancy because the module doesn't particularly need it.
I made the tests pass, but had to remove these two lines. Not sure if they are still necessary as elem isn't a jquery object anymore. Could use a double check on that. I just was getting an undefined error for both...