Conversation
Because: - Users who wish to remap Cmd-Shift-T to Safari's "Undo Close Tab" menu item (providing equivalent, single-tab-reopen functionality) may do so by simply [assigning a keyboard shortcut] in System Preferences -> Keyboard -> Shortcuts And because: - There are other Safari extensions (like [RecoverTabs]) which provide more comprehensive support for Cmd-Shift-T tab-reopening, including the ability to reopen more than one tab - This extension's remapping of Cmd-Shift-T breaks other in-browser Safari plugins that attempt to use Cmd-Shift-T This commit: - Reverts rs#15 and removes support for reopening tabs using Cmd-Shift-T. [RecoverTabs]: https://github.com/Antrikshy/RecoverTabs [assigning a keyboard shortcut]: http://support.apple.com/kb/ph13916
|
👍 |
|
I fully agree! |
|
@reshleman @Wayneoween @tRsk rebuilt version without this shortcut #38 before @rs merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
(providing equivalent, single-tab-reopen functionality) may do so by simply
assigning a keyboard shortcut in System Preferences -> Keyboard -> Shortcuts
And because:
more comprehensive support for Cmd-Shift-T tab-reopening, including the
ability to reopen more than one tab
plugins that attempt to use Cmd-Shift-T
This commit:
Your choice, of course, whether to merge this. Like other users, I prefer to use a different extension for Cmd-Shift-T, and I can't use your extension with it.