Change .umd.cjs dist files to .umd.js to satisfy jsdelivr#1687
Closed
eoghanmurray wants to merge 3 commits intorrweb-io:masterfrom
Closed
Change .umd.cjs dist files to .umd.js to satisfy jsdelivr#1687eoghanmurray wants to merge 3 commits intorrweb-io:masterfrom
.umd.cjs dist files to .umd.js to satisfy jsdelivr#1687eoghanmurray wants to merge 3 commits intorrweb-io:masterfrom
Conversation
…pplication/node` mime type for (see jsdelivr/jsdelivr#18584 ), so we need to revert the extension to `.umd.js` in order that these files can be used in a browser via jsdelivr as per docs (prior to rrweb-io#1033 we shipped these as `.js`)
🦋 Changeset detectedLatest commit: 04cb195 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jun 12, 2025
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
Merged
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jun 12, 2025
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
Contributor
Author
|
#1704 is probably better than this given the 'Dual Package' hazard |
Juice10
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Feb 13, 2026
…th a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - rrweb-io#1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard
Juice10
added a commit
that referenced
this pull request
Feb 13, 2026
* Don't allow video autoplay to automatically unfreeze page. If it's a 'real' playback, there should be a mount or a keyboard event which will serve to unfreeze the page. Also add other non-user events to the list (we really should have an `isUserEvent` function) * Apply formatting changes * Create a new `umd` folder alongside `dist` for output of UMD files with a plain `.js` instead of `.cjs` extension, as the latter won't be served with the correct mime type by jsdelivr - #1687 (just rename `.cjs` to `.js`) was rejected due to the the 'dual package hazard' [1], and produces a warning when run through publint.dev (which was the original motivation for changing to \.cjs) - jsdelivr won't be serving `.cjs` with the correct mime type: jsdelivr/jsdelivr#18584 [1] https://nodejs.org/en/learn/modules/publishing-a-package#the-dual-package-hazard * Update to point to alpha.19 as presumably that's when the umd folder will be available after the changes in this PR * Apply formatting changes * Don't try to create the same directory twice (was failing on packages/packer/umd) * Create thirty-shirts-grow.md * Revert something that shouldn't have gotten into the UMD branch folder * Apply formatting changes * Update vite.config.default.ts * Apply formatting changes * build: include umd builds in published packages Add umd directory to the files array in package.json for all packages to include UMD builds in npm publications. Also update .gitignore to exclude umd folders from version control. * Docs: point to correct file * Remove unused code * docs: update rrweb cdn urls to umd bundles Align README and guide examples with published UMD file locations for rrweb, @rrweb/record, and @rrweb/replay. Update versioned rrweb script examples from 2.0.0-alpha.19 to 2.0.0-alpha.21 in both English and Chinese guides. * build(all): include umd folder in package files --------- Co-authored-by: eoghanmurray <eoghanmurray@users.noreply.github.com> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verdict from jsdelivr is that they are not going to change the
application/nodemime type for (see jsdelivr/jsdelivr#18584 ), so we need to revert the extension to.umd.jsin order that these files can be used in a browser via jsdelivr as per docs (prior to #1033 we shipped these as.js)