chore: drop committed large.md stress fixture, generate on demand#19
Merged
Conversation
The 460 KB / 14.7k-line large.md was generated build output with zero automated consumers (no test/bench/CI reads it). Stop committing it: - delete fixtures/specialized/large.md and gitignore the path so it can't be re-committed - add a `make large-fixture` target that regenerates it via the existing scripts/gen-large-fixture.sh (~1.7s, deterministic, byte-identical) - document the generate → test → delete perf workflow in new docs/TESTING.md Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Review follow-up on the gitignore change in this PR: - gen-large-fixture.sh said the output's `git diff` is meaningful and to "commit the diff" — now contradicts the gitignore. Reword the header comment and the generated file's HEADER to: gitignored, never commit, generate on demand and delete when done. - TESTING.md snapshot-regen example hardcoded a $TMPDIR path (macOS-only; Linux temp_dir is /tmp). Tell the reader to copy the path the test prints instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixtures/specialized/large.mdwas a 460 KB / 14,767-line generated stress document committed to the repo, but no automated test, bench, or CI step consumes it — it only exists for manual perf/stress runs. It is also fully regenerable fromscripts/gen-large-fixture.shin ~1.7s (deterministic, byte-identical output). So there's no reason to carry it in git.Changes
fixtures/specialized/large.md(−14,767 lines).fixtures/specialized/large.mdso it can't be re-committed by accident.make large-fixturetarget that (re)generates it via the existingscripts/gen-large-fixture.sh.docs/TESTING.md— a short testing guide (test layout, how to run via the Makefile, snapshot regeneration) with a Performance / stress testing section documenting the generate → test → delete workflow.Verification
make checkpasses without the fixture (6 snapshot + 4 heading + CLI + unit tests all green) — confirms nothing depended on it.make large-fixtureregenerates the file; verified gitignored (git check-ignorematches, never shows as untracked) and byte-identical to the previously committed version.Independent of the docs-cleanup PR #18 (touches different files; no conflict).
🤖 Generated with Claude Code