Use route path instead of url in metric labels#24
Open
YvesPasteur wants to merge 2 commits intoroylines:masterfrom
Open
Use route path instead of url in metric labels#24YvesPasteur wants to merge 2 commits intoroylines:masterfrom
YvesPasteur wants to merge 2 commits intoroylines:masterfrom
Conversation
nevezide
force-pushed
the
use-routePath
branch
from
b06e371 to
17d120c
Compare
YvesPasteur
force-pushed
the
use-routePath
branch
from
17d120c to
b06e371
Compare
|
Can this please be merged in? This would fix the issue I'm having as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method to deal with the Url doesn't handle very good routes like
/foo/123/barwherefooandbarare resource names and123is a changing id.We change to use the routes as defined in the routers with placeholders, ex : '/foo/{id}/bar'