Skip to content

Analysis: Noise Floor Delta over Z-axis#151

Closed
AhmetCanSolak wants to merge 14 commits intoroyerlab:masterfrom
AhmetCanSolak:noise-floor-estimate
Closed

Analysis: Noise Floor Delta over Z-axis#151
AhmetCanSolak wants to merge 14 commits intoroyerlab:masterfrom
AhmetCanSolak:noise-floor-estimate

Conversation

@AhmetCanSolak
Copy link
Copy Markdown
Collaborator

This PR introduces a way to quantify changes on noise profile spectrum between a denoised array and a noisy array. With current related work we do we need over Z-axis implementation at first but eventually axis can be an optional argument.

@AhmetCanSolak AhmetCanSolak added the enhancement New feature or request label Apr 25, 2022
@AhmetCanSolak AhmetCanSolak self-assigned this Apr 25, 2022
@royerloic
Copy link
Copy Markdown
Member

Closing — Incomplete implementation

Thank you @AhmetCanSolak — the noise floor delta analysis concept is interesting but this PR has unresolved issues:

  1. halfbit_curve() raises NotImplementedError — The core dependency is unimplemented
  2. Demo has undefined variabledenoised_image is used but never defined in demo_noise_floor_delta()
  3. Function signature mismatchnoise_floor_delta() takes 3 params but docstring describes 2

The concept of spectral noise floor analysis is documented for future implementation in code_review_reports/pr_ideas_for_future_work.md with the code and design intent preserved.

@royerloic royerloic closed this Feb 7, 2026
@royerloic royerloic mentioned this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants