This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Open
Conversation
|
why it's failed ? |
It was because the travis build environment was using flutter 1.22.6. I think it would have passed if the environment was upgraded. |
|
Any plans to move it forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the package to null safety by running the
dart migratetool. In addition to these changes, I removed some now-redundant nullability assertions.All unit tests still pass (although I did have to add
TestWidgetsFlutterBinding.ensureInitialized(); not sure what's going on there).