Skip to content
This repository was archived by the owner on Jul 8, 2024. It is now read-only.

Comments

Avoid the "fatal error: module 'FBSDKCoreKit' not found" error on IOS with latest FaceBook SDK#217

Open
smourier wants to merge 1 commit intoroughike:masterfrom
smourier:master
Open

Avoid the "fatal error: module 'FBSDKCoreKit' not found" error on IOS with latest FaceBook SDK#217
smourier wants to merge 1 commit intoroughike:masterfrom
smourier:master

Conversation

@smourier
Copy link

@smourier smourier commented Nov 25, 2019

I've just added a FBSDKCOCOAPODS define that allows the code to compile, as https://github.com/facebook/facebook-ios-sdk/blob/master/FBSDKLoginKit/FBSDKLoginKit/FBSDKLoginButton.h now defines this :

...
#if defined BUCK || defined FBSDKCOCOAPODS || defined __cplusplus
#import <FBSDKCoreKit/FBSDKCoreKit.h>
#else
@import FBSDKCoreKit;
#endif
...

@ksheremet
Copy link

That would be relying on an implementation detail -- wouldn't the "Right Thing To Do" be enabling modular_headers (see #214)?

@smourier
Copy link
Author

I've not tested what you proposed, I've only tested my change. I'm not enough of an expert in iOS to be sure what's the "right thing to do". Yet, I'm pretty sure the bad thing to do is change version target like others proposed in #214 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants