This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Avoid the "fatal error: module 'FBSDKCoreKit' not found" error on IOS with latest FaceBook SDK#217
Open
smourier wants to merge 1 commit intoroughike:masterfrom
Open
Avoid the "fatal error: module 'FBSDKCoreKit' not found" error on IOS with latest FaceBook SDK#217smourier wants to merge 1 commit intoroughike:masterfrom
smourier wants to merge 1 commit intoroughike:masterfrom
Conversation
|
That would be relying on an implementation detail -- wouldn't the "Right Thing To Do" be enabling |
Author
|
I've not tested what you proposed, I've only tested my change. I'm not enough of an expert in iOS to be sure what's the "right thing to do". Yet, I'm pretty sure the bad thing to do is change version target like others proposed in #214 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just added a FBSDKCOCOAPODS define that allows the code to compile, as https://github.com/facebook/facebook-ios-sdk/blob/master/FBSDKLoginKit/FBSDKLoginKit/FBSDKLoginButton.h now defines this :