Add in a test for unbounded serialized take. (backport #592)#593
Open
mergify[bot] wants to merge 1 commit intolyricalfrom
Open
Add in a test for unbounded serialized take. (backport #592)#593mergify[bot] wants to merge 1 commit intolyricalfrom
mergify[bot] wants to merge 1 commit intolyricalfrom
Conversation
This is actually handled differently in rmw_fastrtps_cpp now, so we should have a separate test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1a0d6a0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already had a test for serialized_take, but it was only a simple type. Unbounded types are handled differently in rmw_fastrtps_cpp now, so we should have a separate test for it.
This will go along with a series of fixes to rmw_fastrtps_cpp
Is this user-facing behavior change?
No.
Did you use Generative AI?
Yes, I used Claude Opus 4.7
Additional Information
This should be merged after ros2/rmw_fastrtps#880 , ros2/rmw_fastrtps#879 , and ros2/rmw_fastrtps#881 .
This should be backported to Lyrical.
This is an automatic backport of pull request #592 done by Mergify.