[jazzy] Fix for a possible race condition in compression writer on close (backport #2362)#2381
Merged
MichaelOrlov merged 1 commit intojazzyfrom Apr 8, 2026
Merged
Conversation
It was a possible race condition in the close() method. If all compressor threads are busy compressing files, we may end up exiting before scheduling to compress the last file, which would lead to the issue when the last file appears uncompressed. Signed-off-by: Michael Orlov <morlovmr@gmail.com> (cherry picked from commit fd17c38)
MichaelOrlov
changed the title
MichaelOrlov
approved these changes
Mar 16, 2026
Contributor
MichaelOrlov
left a comment
MichaelOrlov
left a comment
There was a problem hiding this comment.
LGTM with green CI.
Contributor
|
Pulls: #2381
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was possible a race condition in the close() method. If all compressor threads are busy compressing files, we may end up exiting before scheduling to compress the last file, which would lead to the issue when the last file appears uncompressed.
The race condition was resolved by sequentially closing the current file, waiting until all compressors finish and then compressing the last file in the current thread instead of pushing the last file into the compressors' queue and stopping all compressors.
Fixes # (issue) N/A
Is this user-facing behavior change?
No.
Did you use Generative AI?
Yes. Codex GPT-5.4 to help with comments and code cleanup
Additional Information
Can be backported
This is an automatic backport of pull request #2362 done by [Mergify](https://mergify.com).