Open
Conversation
- Also added a new test to validate persistent cli mode. Co-authored-by: ap-apexai <anup.patel@apex.ai> Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
--persistentoption toros2 bag playverb.What changed:
• Added --persistent to the ros2 bag play CLI in play.py.
• Added end-to-end test coverage in test_rosbag2_play_end_to_end.cpp for the new player lifecycle behavior.
Is this user-facing behavior change?
Yes.
When
--persistentis enabled, the player process no longer exits when playback stops, either because the bag reached the end or because playback was stopped through theStopservice call. Instead, the process remains alive until it is explicitly terminated. This makes the player usable for repeated service-driven playback sessions without restarting theros2 bag playcommand.Without
--persistent, the existing behavior is unchanged: the player exits when playback stops or completes.Did you use Generative AI?
Yes. Codex gpt-5/4 was used to help with README.md file updates.
Additional Information
Can be backported