Conversation
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
and the `source` command is preferred fish-shell/fish-shell#310 Signed-off-by: ruffsl <roxfoxpox@gmail.com>
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
This should probably wait until fish support is available in various other parts of the pipeline (e.g. ament_package, colcon).
| @@ -0,0 +1,31 @@ | |||
| # reduced from ament_package/template/package_level/local_setup.fish.in | |||
There was a problem hiding this comment.
This file doesn't exist atm?
| # limitations under the License. | ||
|
|
||
| if type register-python-argcomplete3 > /dev/null 2>&1 | ||
| eval "register-python-argcomplete3 --shell fish ros2 | source" |
There was a problem hiding this comment.
Using eval and source looks weird - are both really necessary?
There was a problem hiding this comment.
The . command is deprecated as the source command is preferred: fish-shell/fish-shell#310
But I suppose the eval might not be needed. I was just mimicking the style in bash file.
Why was eval used there?
There was a problem hiding this comment.
Because it is the recommended approach described in the argcomplete docs: https://argcomplete.readthedocs.io/en/latest/#synopsis
What else would to be need added or ported? |
I don't know out of my head. I would suggest to work on each of them incrementally and then see if anything else is missing. |
|
@sloretz FYI 🐟 |
|
@ruffsl What needs to be done to get this out of draft status? |
|
@gbiggs , it's been a while, but I think dirks's comment on support available for the rest of the pipeline still stands. #326 (review) I can't remember what may still be missing here, but ros2cli and setup sh scripts may have changed some sense I started this draft. |
|
How could I test this PR? |
|
Is there any progress? |
I'm not aware of anything moving on this. If the merge conflicts are sorted out and it seems to work, then it'd be worth another review.
I think you're going to want to rebase this PR and then sort out any merge conflicts that remain. After that, you should be able to build from source and test it out. |
…low PEP8 (ros2#326) Signed-off-by: William Woodall <william@osrfoundation.org> Signed-off-by: William Woodall <william@osrfoundation.org>
|
Closing because it has been years. Feel free to reopen. |
- ros2#326 Signed-off-by: sunrisepeak <speakshen@163.com>
- ament/ament_package#164 - ros2#326 Signed-off-by: sunrisepeak <speakshen@163.com>
- ament/ament_package#164 - ros2#326 Signed-off-by: sunrisepeak <speakshen@163.com>
|
@audrow hi, I want to push the feature merge to rolling and lazzy branch I already test on ubuntu 24.04, it's ok. can you help me to review ti? |
9 participants
This adds completion support for fish shell: https://fishshell.com
Given that argcomplete works for fish as well: kislyuk/argcomplete#260