Force canonical URLs to include ROS distro#6159
Open
attu0 wants to merge 1 commit intoros2:rollingfrom
Open
Conversation
Author
|
@fujitatomoya Thanks for the guidance! I’ve recreated the change as a clean commit on top of |
fujitatomoya
requested changes
Jan 13, 2026
tfoote
requested changes
Jan 29, 2026
Contributor
tfoote
left a comment
There was a problem hiding this comment.
This doesn't appear to fix the problem. Running make html with this patch The canonical urls aren't changed.
This is inside the sphinx multi version logic which is only going to trigger if you use sphinx multi version not the basic keys. RUnning this version the canonical urls arn't changed for make html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes canonical URL generation for sphinx-multiversion builds by
explicitly setting
html_baseurlto include the ROS distribution(e.g.
https://docs.ros.org/en/rolling).This prevents mirrors or alternate build environments from generating
incorrect canonical URLs that omit the ROS distribution or use
non-official domains.
Fixes #6112.
Did you use Generative AI?
Yes — ChatGPT (for guidance and explanation only).
Additional Information
rolling