Single Source of truth for contributing guidelines#5246
Single Source of truth for contributing guidelines#5246Nils-ChristianIseke wants to merge 8 commits intoros2:rollingfrom
Conversation
Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
in general, i agree with this approach to reduce the maintenance cost and redundancy. (we redeploy the documentation nightly as described here, so it would not be problem.)
there is a couple of suggestions.
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
76ae27b to
9f71c8f
Compare
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
kscottz
left a comment
There was a problem hiding this comment.
I am really ambivalent about this pull request but I am not going to get in the way on it getting merged. I get that we should aim for "DRY" but I also think you can take certain rules a little too far.
Is it too much to ask that less README.MD on the repo you just cloned actually contains instructions on how to build the repository? Maybe just an abridged version of the instructions?
|
|
||
| Contributions to this site are most welcome. | ||
| Please see the [Contributing to ROS 2 Documentation](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.html) page to learn more. | ||
| Please see the [Contributing to ROS 2 Documentation](https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.html) page to learn how to contribute. |
There was a problem hiding this comment.
I don't know if we necessarily want to frame this as solely contributing versus "building and contributing."
|
Thank you for your review. I came across this because the documentation deviated from the instructions in the readme file. And one part of the information in the documentation was incorrect. However, I agree with you that having that information in the README is not bad. I could check if it is possible to integrate the parts of the rst into this markdown or vice versa. |
|
@fujitatomoya @kscottz friendly ping :).
Happy for your thoughts :) |
|
I say keeping this PR 👍 @kscottz what do you think? |
|
@Mergifyio rebase |
❌ Base branch update has failedDetailsGit reported the following error: |
|
@Nils-ChristianIseke sorry for being late to get back to you. can you rebase this against current rolling branch? |
Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
|
it just says |
We should have a single source of truth for the contributing guidelines.