Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,19 @@ class LifecycleNodeInterface
LifecycleNodeInterface() {}

public:
enum class CallbackReturn : uint8_t
{
SUCCESS = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_SUCCESS,
FAILURE = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_FAILURE,
ERROR = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_ERROR
};

/// Callback function for configure transition
/*
* \return SUCCESS by default
*/
Comment on lines -63 to -66

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the removal of this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't intentional it was mistake I am sorry for that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolving this, since it has not been addressed

enum class CallbackReturn : uint8_t
{
/// The callback completed successfully and the transition can proceed.
SUCCESS = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_SUCCESS,

/// The callback did not succeed, and the transition will not proceed.
/// The node remains in its current state.
FAILURE = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_FAILURE,

/// An error occurred during the callback execution.
/// The node transitions to an error handling state.
ERROR = lifecycle_msgs::msg::Transition::TRANSITION_CALLBACK_ERROR,
};
RCLCPP_LIFECYCLE_PUBLIC
virtual CallbackReturn
on_configure(const State & previous_state);
Expand Down