Revert "Adding explicit constructors (#129)"#132
Merged
clalancette merged 1 commit intorollingfrom Jun 26, 2024
Merged
Conversation
This reverts commit aea0e9f.
Contributor
Author
|
CI:
|
ahcorde
approved these changes
Jun 18, 2024
Contributor
|
I almost have a patch for this packages, i will open it today. Just in case you want to wait |
Contributor
Contributor
|
@clalancette I can open any other PR, if there are more packages failing |
Contributor
Author
Hm. Well, the fact that we broke downstream packages makes me inclined to revert this, even if we can fix the downstreams. At the very least we should start by deprecating this if we want to change the API like this. But let's see what the maintainers in ros-perception/perception_pcl#457 have to say first. |
Contributor
Author
|
I discussed this with @ahcorde , and we agreed for now to merge this in to get Rolling regression free. We'll eventually follow-up with this and ros-perception/perception_pcl#457 again in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit aea0e9f.
This is causing downstream packages to fail to compile; see for example https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__pcl_ros__ubuntu_noble_amd64__binary/23/console . I verified that removing this commit causes those packages to compile again. If we want to do this, we may have to be a little more careful on how this is done.
@CursedRock17 @ahcorde FYI.