Skip to content

rates_ vector out of channel order#111

Open
andermi wants to merge 1 commit intoros2:rollingfrom
andermi:andermi/fix_latesttime_rateconfig
Open

rates_ vector out of channel order#111
andermi wants to merge 1 commit intoros2:rollingfrom
andermi:andermi/fix_latesttime_rateconfig

Conversation

@andermi
Copy link
Copy Markdown
Contributor

@andermi andermi commented Jan 23, 2024

rates_ vector out of channel order when user-specified RateConfig vector provided

fixes #110

…tor provided

Signed-off-by: Michael Anderson <anderson@mbari.org>
@clalancette
Copy link
Copy Markdown
Contributor

I'm honestly not sure that this is the correct fix. From what I can tell of the current code, it is actually possible (if non-intuitive) to configure the rates properly. You just need to call setRateConfigPerMessage of the correct size, and then all of the calls to add will reference the correct configuration as they are created. And then sort_indices will actually sort them by their expiry time.

However, I'm not 100% sure of all of that. What I think we really need is an example/test that shows the problem that we are trying to solve, and the way we would solve it with the current code. Then we can consider whether this proposal solves it better.

@andermi
Copy link
Copy Markdown
Contributor Author

andermi commented Feb 12, 2024

Sounds good! I can try adding a test to replicate #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there a bug in Latest time policy rates_ initialization?

2 participants