Merged
Conversation
- Add specialized streamPrimitiveVector overloads for std::vector<bool> to handle proxy object references instead of using memcpy - Add adapter for incompatible controller_manager_msgs::ControllerState between ROS1 Noetic and ROS2 Jazzy, converting common fields (name, state, type) - Update CMakeLists.txt to include the ControllerState adapter This resolves compilation errors "lvalue required as unary '&' operand" and linker errors for undefined ControllerState Factory methods. Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
- Add matrix strategy to test multiple ROS 1/ROS 2 combinations - Add ROS-O (one) testing on Ubuntu 22.04 with ROS 2 Humble - Add ROS-O (one) testing on Ubuntu 24.04 with ROS 2 Jazzy - Keep existing Noetic + Rolling test for compatibility - Update to use iory/setup-ros@add-ros-one-support for ROS-O support Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
This commit adds support for testing ros1_bridge with ROS-O (ROS One) and fixes compatibility issues for noetic + rolling combinations. Changes: - Add copyright header to controller_manager_msgs_controller_state_adapter.cpp to satisfy ROS 2 linting requirements - Skip pep257 test to avoid Python 3.8/ament_pep257 0.11.4 compatibility issue on Ubuntu 20.04 (Focal) with ROS 2 Rolling The pep257 linter has an incompatibility with Python 3.8 that causes 'ValueError: too many values to unpack (expected 3)' when running tests. This is a known issue with ament_pep257 0.11.4 on older Python versions. Signed-off-by: Iori Yanokura <ab.ioryz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR ros2#462
Summary
This PR adds support for testing ros1_bridge with ROS-O (ROS One) and fixes compatibility issues when testing with the noetic + rolling combination.
Changes
Copyright header
controller_manager_msgs_controller_state_adapter.cpppep257 compatibility fix
CI workflow updates
Build fixes
Related PRs
This PR is part of a series to add ROS-O support to the ROS tooling ecosystem:
Together, these PRs enable:
Testing
With these changes, the CI successfully tests:
All tests pass successfully with these combinations.
Technical details
The pep257 skip is necessary because:
Breaking changes
None. These are additive changes that:
Signed-off-by: Iori Yanokura ab.ioryz@gmail.com