Skip to content

Conversation

@tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Jan 6, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses ros-navigation/navigation2#5746
Does this PR contain AI-generated software? Does it matter at this point?

Description of contribution in a few bullet points

  • Added docs for AxisGoalChecker

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check CI, there's a failure

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@tonynajjar
Copy link
Contributor Author

tonynajjar commented Jan 6, 2026

@SteveMacenski the image is generated with a python script. I'm wondering how to make it easy for anyone to update it in the future. Options:

1- Store the python script somewhere
2- Generate an svg - I'm not sure how easily editable it is but better than png
3- YOLO, no edits allowed, only photoshop

Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@SteveMacenski
Copy link
Member

I suppose you could add that python script here in the configuration/packages/nav2_controller-plugins directory just for sake keeping. I doubt we'd ever use it again but no reason to throw away good information, I suppose.

tonynajjar and others added 3 commits January 6, 2026 18:16
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar@dexory.com>
@SteveMacenski SteveMacenski merged commit ec66162 into ros-navigation:master Jan 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants