-
Notifications
You must be signed in to change notification settings - Fork 67
revise editors chapter for #487 #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And rm previously separate 'Asking for more details' sub-section
|
@maelle This would be ready for review, but the Render Book workflow is failing, in ways I think related to babelquarto. The pandoc render of the English version works fine, then it moves on to the Spanish version and fails soon after then. I've seen those fails on other PR renders before, but they've always auto-resolved. This one seems not to want to do that. Any insights would be greatly appreciated, thanks! |
|
I'm investigating the CI problem, we had issues for a while recently then I fixed one workflow file and forgot to update the others. |
maelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Soon we'll need a whole book for editors 😅
| ``` | ||
| This will also add the tag `1/editor-checks` to the issue. | ||
|
|
||
| #### Statistical software submissions {#eic-stats-submissions} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this content also exist as a short video intro to the stat system or would that get out of date too quickly?
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
|
@mpadge could you please link the issues this will close, to this PR? With the "Fix #" syntax. |
|
@mpadge please also update the booknews. |
maelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! It's not a small amount of work and will make the chapter so much more useful.
| - Initiate discussions in the rOpenSci Slack `#editors-only` channel through summarising the (pre-)submitted/referred software, along with any concerns the EiC might have. | ||
| - If the EiC feels they haven't received enough answers after a day or two, they can ping all editors. | ||
| - The EiC should seek other opinions on submissions which are beyond their own areas of expertise. | ||
| - Statistical software should be considered in scope as long as it can comply with at least half of all [applicable standards (general and at least one category)](https://stats-devguide.ropensci.org/standards.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an EiC who's not a stat editor, isn't this still a lot of work/stuff to learn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be indeed! We're hoping to move towards having stats people do EiC rotations, and then we'll have a team of more than just me on hand to answer questions. Until then, that's at attempt to provide minimal context that indicates that EiC responsibilities for stats submissions are even less than for normal submissions. Does that make sense?
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
|
@maelle Review re-requested please 🙏 And the last commit above will close the long-standing issue 🎉 |
|
Doesn't that PR close other issues? Thanks a lot for your work on this. I will create the translations but in another PR because I had merged main into this branch 😭 I'll create a new branch then cherry pick all commits. |
|
New branch is #976 |
No description provided.