Skip to content

Conversation

@mpadge
Copy link
Member

@mpadge mpadge commented Dec 2, 2025

No description provided.

@mpadge
Copy link
Member Author

mpadge commented Dec 3, 2025

@maelle This would be ready for review, but the Render Book workflow is failing, in ways I think related to babelquarto. The pandoc render of the English version works fine, then it moves on to the Spanish version and fails soon after then.

I've seen those fails on other PR renders before, but they've always auto-resolved. This one seems not to want to do that. Any insights would be greatly appreciated, thanks!

@maelle
Copy link
Member

maelle commented Dec 5, 2025

I'm investigating the CI problem, we had issues for a while recently then I fixed one workflow file and forgot to update the others.

Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Soon we'll need a whole book for editors 😅

```
This will also add the tag `1/editor-checks` to the issue.

#### Statistical software submissions {#eic-stats-submissions}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this content also exist as a short video intro to the stat system or would that get out of date too quickly?

mpadge and others added 7 commits December 8, 2025 10:43
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
@maelle
Copy link
Member

maelle commented Dec 8, 2025

@mpadge could you please link the issues this will close, to this PR? With the "Fix #" syntax.

@maelle
Copy link
Member

maelle commented Dec 8, 2025

@mpadge please also update the booknews.

Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! It's not a small amount of work and will make the chapter so much more useful.

- Initiate discussions in the rOpenSci Slack `#editors-only` channel through summarising the (pre-)submitted/referred software, along with any concerns the EiC might have.
- If the EiC feels they haven't received enough answers after a day or two, they can ping all editors.
- The EiC should seek other opinions on submissions which are beyond their own areas of expertise.
- Statistical software should be considered in scope as long as it can comply with at least half of all [applicable standards (general and at least one category)](https://stats-devguide.ropensci.org/standards.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an EiC who's not a stat editor, isn't this still a lot of work/stuff to learn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can be indeed! We're hoping to move towards having stats people do EiC rotations, and then we'll have a team of more than just me on hand to answer questions. Until then, that's at attempt to provide minimal context that indicates that EiC responsibilities for stats submissions are even less than for normal submissions. Does that make sense?

mpadge and others added 6 commits December 8, 2025 15:17
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
mpadge and others added 6 commits December 8, 2025 15:28
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
@mpadge mpadge requested a review from maelle December 8, 2025 16:54
@mpadge
Copy link
Member Author

mpadge commented Dec 8, 2025

@maelle Review re-requested please 🙏 And the last commit above will close the long-standing issue 🎉

@maelle maelle marked this pull request as ready for review December 9, 2025 08:36
@maelle
Copy link
Member

maelle commented Dec 9, 2025

Doesn't that PR close other issues?

Thanks a lot for your work on this.

I will create the translations but in another PR because I had merged main into this branch 😭 I'll create a new branch then cherry pick all commits.

@maelle maelle closed this Dec 9, 2025
@mpadge
Copy link
Member Author

mpadge commented Dec 9, 2025

New branch is #976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants