Validate whether process belongs to the container's NetNS#70
Open
naoki9911 wants to merge 1 commit intorootless-containers:masterfrom
Open
Validate whether process belongs to the container's NetNS#70naoki9911 wants to merge 1 commit intorootless-containers:masterfrom
naoki9911 wants to merge 1 commit intorootless-containers:masterfrom
Conversation
ignores any sockets created in non-container NetNS including nested one. Signed-off-by: Naoki MATSUMOTO <naoki@pibvt.net>
Member
|
Thank you, but this still does not seem to fix: I also wonder if this PR disables the entire acceleration for |
Member
|
For #65, this seems to work as a workaround |
Collaborator
Author
Thanks, the issue seems to stem from other reasons.
Yes, this disables entire acceleration including |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bypass4netns handles all sockets in the container NetNS.
However, in the nested NetNS environment, it wrongly bypasses sockets in the nested NetNS.
It causes the following issues.
#65
#66
This patch makes bypass4netns ignore any sockets created in non-container NetNS including nested ones.