Skip to content

[tree] Resolve name truncation issues in TTree::Scan #21383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
al-025 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[tree] Resolve name truncation issues in TTree::Scan #21383

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36b6acc
[tree] Show truncation with ... in column name headers for Scan()
al-025 Feb 24, 2026
02410bc
[tree] Dynamically resize column widths to fit names for Scan()
al-025 Feb 26, 2026
5038756
[tree] Comment non-obvious column name truncation for Scan()
al-025 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tree/treeplayer/src/TTreePlayer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2456,6 +2456,7 @@ Long64_t TTreePlayer::Scan(const char *varexp, const char *selection,
UInt_t ui;
UInt_t lenmax = 0;
UInt_t colDefaultSize = 9;
UInt_t colMaxResizeWidth = 20;
UInt_t colPrecision = 9;
std::vector<TString> colFormats;
std::vector<Int_t> colSizes;
Expand All @@ -2481,6 +2482,7 @@ Long64_t TTreePlayer::Scan(const char *varexp, const char *selection,
opt.Remove(start,length("size")+numlen);

colDefaultSize = atoi(num.Data());
colMaxResizeWidth = colDefaultSize;
colPrecision = colDefaultSize;
if (colPrecision>18) colPrecision = 18;
}
Expand Down Expand Up @@ -2632,9 +2634,10 @@ Long64_t TTreePlayer::Scan(const char *varexp, const char *selection,
}
var = new TTreeFormula* [ncols];

for(ui=colFormats.size();ui<ncols;++ui) {
for (ui = colFormats.size(); ui < ncols; ++ui) {
colFormats.push_back(defFormat);
colSizes.push_back(colDefaultSize);
UInt_t nameWidth = cnames[ui].size();
colSizes.push_back(std::clamp(nameWidth, colDefaultSize, colMaxResizeWidth));
}

//*-*- Create the TreeFormula objects corresponding to each column
Expand Down Expand Up @@ -2691,7 +2694,13 @@ Long64_t TTreePlayer::Scan(const char *varexp, const char *selection,
if (hasArray) onerow += "* Instance ";
for (ui=0;ui<ncols;ui++) {
TString numbFormat = Form("* %%%d.%ds ",colSizes[ui],colSizes[ui]);
onerow += Form(numbFormat.Data(),var[ui]->PrintValue(-1));
TString varName = var[ui]->PrintValue(-1);
if (Int_t(varName.size()) > colSizes[ui]) {
varName.Resize(std::max(1, colSizes[ui] - 3));
varName += "...";
}
// varName will be truncated further if necessary here (ie if colSizes[ui]<=3)
onerow += Form(numbFormat.Data(), varName.Data());
}
if (fScanRedirect)
out<<onerow.Data()<<"*"<<std::endl;
Expand Down
Loading