[6.34][FP][core] Remove potential leftover paths from future ROOT versions #20671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove within thisroot.(c)sh potential leftover paths from future ROOT versions
Test Results 11 files 11 suites 1d 15h 49m 36s ⏱️ For more details on these failures, see this check. Results for commit 5c843d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FP of #20654
6.34 is EOL but it seems some exps are using it since it's the last supporting odbc
https://root-forum.cern.ch/t/the-thisroot-sh-misbahes-in-root-6-34/64513/11?u=ferhue
The other fix in thisroot drop_from_path was also pushed last week to this branch, so for consistency adding it here, too.
Side note: should the CI for 6.34 be disabled?