Python Tutorials for CNN, Higgs and RNN added in Tutorials/TMVA#10442
Python Tutorials for CNN, Higgs and RNN added in Tutorials/TMVA#10442Neel-Shah-29 wants to merge 1 commit intoroot-project:masterfrom
Conversation
|
Can one of the admins verify this patch? |
|
This pull request introduces 20 alerts when merging 8cd3b57 into 7e709f8 - view on LGTM.com new alerts:
|
lmoneta
left a comment
There was a problem hiding this comment.
We should pass the tutorial options from command line of by defining a function with parameters.
All 3 tutorials should also include PyTorch and Keras and have a way to detect if PyTorch and Keras are installed or not. If they are not installed the corresponding method should not be run. This would avoid adding a veto for the tutorials in the CMake file in tutorials.
| # Define the Options and number of threads | ||
|
|
||
|
|
||
| opt=[1,1,1,1,1] |
There was a problem hiding this comment.
We could use a more Pythonic way to pass the option to the tutorial. Maybe some command line argument ?
|
The Python versions of these tutorials have been merged with #11069. Thank you very much for your initial work! |
This Pull request: Adds the Python Tutorials to several C files in Tutorials/TMVA.
One of the tasks of Pythonization project for Gsoc was to add Python tutorials for C files in Tutorials/TMVA.
I have added python tutorials for TMVA_Higgs_Classification.C , TMVA_CNN_Classification.C and TMVA_RNN_Classification.C.
The notebooks for the same can be found here.
We can also make an improvement regarding adding a PyTorch model for RNN and train it, its implementation can be found here. We can add this improvement once reviewed.
Checklist: