Skip to content

Refactor test names and test methods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varokas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor test names and test methods #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/com/bank/service/internal/DefaultDepositServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void setUp() {
}

@Test
public void testDeposit() {
public void testDepositAddsAmountToInitialBalance() {
double depositAmount = 100.00;
depositService.setMinimumDepositAmount(5.00);
try {
Expand All @@ -49,7 +49,7 @@ public void testDeposit() {
}

@Test
public void testDepositBelowMinimumAmount() throws InvalidDepositAmountException {
public void testDepositBelowMinimumAmountThrowsExceptionAndLeaveCurrentBalance() throws InvalidDepositAmountException {
double depositAmount = 4.99;
depositService.setMinimumDepositAmount(5.00);
try {
Expand Down
32 changes: 25 additions & 7 deletions src/test/com/bank/service/internal/DefaultTransferServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,28 @@ public void setUp() {
}

@Test
public void testTransfer() throws InsufficientFundsException {
public void testTransferMoveMoneyFromOneAccountToAnother() throws InsufficientFundsException {
double transferAmount = 100.00;

TransferReceipt receipt = transferService.transfer(transferAmount, A123_ID, C456_ID);

assertThat(receipt.getTransferAmount(), equalTo(transferAmount));
assertThat(receipt.getFinalSourceAccount().getBalance(), equalTo(A123_INITIAL_BAL - transferAmount));
assertThat(receipt.getFinalDestinationAccount().getBalance(), equalTo(C456_INITIAL_BAL + transferAmount));
transferService.transfer(transferAmount, A123_ID, C456_ID);

assertThat(accountRepository.findById(A123_ID).getBalance(), equalTo(A123_INITIAL_BAL - transferAmount));
assertThat(accountRepository.findById(C456_ID).getBalance(), equalTo(C456_INITIAL_BAL + transferAmount));
}

@Test
public void testTransferProduceCorrectReciept() throws InsufficientFundsException {
double transferAmount = 100.00;

TransferReceipt receipt = transferService.transfer(transferAmount, A123_ID, C456_ID);

assertThat(receipt.getTransferAmount(), equalTo(transferAmount));
assertThat(receipt.getFinalSourceAccount().getBalance(), equalTo(A123_INITIAL_BAL - transferAmount));
assertThat(receipt.getFinalDestinationAccount().getBalance(), equalTo(C456_INITIAL_BAL + transferAmount));
}

@Test
public void testInsufficientFunds() {
public void testTransferInsufficientFundsThrowsException() {
double overage = 9.00;
double transferAmount = A123_INITIAL_BAL + overage;

Expand All @@ -60,7 +67,18 @@ public void testInsufficientFunds() {
assertThat(ex.getTargetAccountId(), equalTo(A123_ID));
assertThat(ex.getOverage(), equalTo(overage));
}
}

@Test
public void testTransferInsufficientFundsLeaveAmountOnBothAccountUnchanged() {
double overage = 9.00;
double transferAmount = A123_INITIAL_BAL + overage;

try {
transferService.transfer(transferAmount, A123_ID, C456_ID);
} catch (InsufficientFundsException ex) {
}

assertThat(accountRepository.findById(A123_ID).getBalance(), equalTo(A123_INITIAL_BAL));
assertThat(accountRepository.findById(C456_ID).getBalance(), equalTo(C456_INITIAL_BAL));
}
Expand Down
18 changes: 16 additions & 2 deletions src/test/com/bank/service/internal/VariableFeePolicyTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,34 @@
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;

import org.junit.Before;
import org.junit.Test;

import com.bank.service.internal.VariableFeePolicy;

public class VariableFeePolicyTests {

private VariableFeePolicy feePolicy;

@Before
public void before() {
feePolicy = new VariableFeePolicy();
}

@Test
public void testVariableFee() {
VariableFeePolicy feePolicy = new VariableFeePolicy();
public void testVariableFeeCalculateByPercentage() {
feePolicy.setFeePercentage(1.00); // 1% fee
feePolicy.setMinimumFee(1.00); // $1.00

assertThat(feePolicy.calculateFee(1000.00), equalTo(10.00));
assertThat(feePolicy.calculateFee(100.00), equalTo(1.00));
}

@Test
public void testVariableFeeCalculateRespectMinimumFee() {
feePolicy.setFeePercentage(1.00); // 1% fee
feePolicy.setMinimumFee(1.00); // $1.00

assertThat(feePolicy.calculateFee(10.00), equalTo(1.00));
}
}