fix: swap SafeAreaView for react-native-safe-area-context (closes #539)#577
Open
marcm0de wants to merge 1 commit intoroninoss:mainfrom
Open
fix: swap SafeAreaView for react-native-safe-area-context (closes #539)#577marcm0de wants to merge 1 commit intoroninoss:mainfrom
marcm0de wants to merge 1 commit intoroninoss:mainfrom
Conversation
…ontext (closes roninoss#539) React Native's built-in SafeAreaView only works on iOS and doesn't properly handle notches/dynamic islands on all devices. react-native-safe-area-context is already a dependency (used in SafeAreaProvider in layout files) and is the recommended replacement. Updated both base and nativewindui Container.tsx.ejs templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #539 — swaps
SafeAreaViewfromreact-nativetoreact-native-safe-area-contextin the Container component templates.Problem
React Native's built-in
SafeAreaViewonly works on iOS and doesn't properly handle notches, dynamic islands, or Android safe areas. The project already usesreact-native-safe-area-context(SafeAreaProviderin layout files), but the Container components still import fromreact-native.Changes
cli/src/templates/base/components/Container.tsx.ejs— Import fromreact-native-safe-area-contextinstead ofreact-nativecli/src/templates/packages/nativewindui/components/Container.tsx.ejs— Same changeWhy this is safe
react-native-safe-area-contextis already a dependency in generated projects (used bySafeAreaProviderin App.tsx/layout files). This is just making the Container component consistent with the rest of the template.