Merged
Conversation
ETag is a response header sent by the server; the client sends If-None-Match. Rephrased to: 'sends If-None-Match with the cached ETag' to avoid implying ETag is a request header. Addresses Copilot review comment on #14.
There was a problem hiding this comment.
Pull request overview
Updates the docs landing page to correctly describe ETag-based caching behavior, clarifying that the client sends If-None-Match using a cached ETag (and that ETag itself is a response header).
Changes:
- Reworded the “Two-layer caching” bullet to avoid implying
ETagis a request header. - Clarified the 304 (“Not Modified”) behavior when the cached ETag matches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Copilot review comment on #14.
ETagis a response header sent by the server; the client sendsIf-None-Match. The previous wording ('sendsIf-None-Match/ ETag headers') implied ETag was a request header.Changed to: 'sends
If-None-Matchwith the cached ETag so unchanged responses return HTTP 304'