Fix build failure: remove redundant License classifier#16
Merged
ronaldvdmeer merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
PEP 639 / setuptools >=68 rejects 'License :: OSI Approved' classifiers when a license SPDX expression is already set via the 'license' key. Remove the classifier — license = "MIT" is sufficient and already satisfies the HA third-party library policy requirement.
There was a problem hiding this comment.
Pull request overview
Removes a packaging metadata conflict in pyproject.toml that causes builds to fail under setuptools’ PEP 639 validation, by dropping the redundant License :: trove classifier while retaining the SPDX license expression.
Changes:
- Removed
License :: OSI Approved :: MIT Licensefrom[project].classifiersto avoid conflicting license metadata. - Keeps
license = "MIT"as the single source of license metadata.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
License :: OSI Approved :: MIT Licenseclassifier that was added in #15, which broke the CI build.Root cause
PEP 639 (adopted in setuptools ≥68) rejects
License ::classifiers when a SPDX license expression is already set via thelicensekey. The two representations conflict and setuptools now raisesInvalidConfigError.Fix
Remove the classifier. The existing
license = "MIT"entry is a valid SPDX expression and already satisfies the Home Assistant third-party library policy requirement — the licence is visible on PyPI through both the metadata field and theLICENSEfile bundled in the distribution.