Refactor mobile streaming, drawers, and diff rendering#11
Open
ronak-guliani wants to merge 3 commits into
Open
Refactor mobile streaming, drawers, and diff rendering#11ronak-guliani wants to merge 3 commits into
ronak-guliani wants to merge 3 commits into
Conversation
… fix error handling, remove dead code Priority 1 (Blocking): - Document why app/_layout.tsx uses bootstrap() directly (app startup vs user-driven connection) - Restore comment in connect.tsx explaining connect-stage error handling via store side-effect - Remove dead requireRefreshSuccess flag and related logic (refresh is always best-effort) Priority 2 (Recommended): - Export BootstrapResultError and BootstrapResultSuccess discriminant types for better type reusability - Update tests to remove requireRefreshSuccess dead code test case All fixes maintain backward compatibility while improving code clarity and maintainability.
…bile-architecture-consistency
- Split sidebar and diff into separate drawers - Add telemetry and session diff panel plumbing - Prepare mobile chat rendering for smoother streaming
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Not runconnectAndBootstrapbehavior.toErrorMessagenormalization.