!perf: Use string for iteration and error reporting#24
Open
!perf: Use string for iteration and error reporting#24
Conversation
Owner
Author
|
Alternatively, the error reporting can be changed to avoid needing instead of: But this can still be replicated by the API user if necessary. |
The string type is smaller than a byte slice and can be copied much faster than []byte on modern 64-bit systems. Drawbacks: this change requires the use of unsafe. Type Error is no longer required to be type-parameterized but it's preserved as Error[S] in order to remain backward compatible. The type parameter can be removed in a new major version.
Remove type parameter because the Error type requires backward incompatible changes anyway.
c663540 to
b9b9f2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stringtype is smaller than a[]byteand can be copied much faster. Copying structs <= 32 bytes on modern 64-bit systems is essentially free whereasError[[]byte]is 40 bytes widemaking jscan work faster with
stringthan with[]byte. This PR eliminates the overhead at the cost of backward compatibility improving performance by about 14%.unsafe.Error:Src.Erroris no longer required to be type-parameterized.An alternative solution is presented in #25.
Benchmark results: