Open
Conversation
romshark
requested changes
Dec 16, 2023
Owner
romshark
left a comment
There was a problem hiding this comment.
It would make sense to update the documentation as well by adding the following sentence where relevant:
If fn returns true, <FuncName> immediately stops and returns ErrorCodeCallback.
Author
Should those be in docstrings or distributed across the code by itself? |
Owner
In the doc comments of the individual functions/methods, like: // ScanOne calls fn for every encountered value including objects and arrays.
// When an object or array is encountered fn will also be called for each of its
// member and element values.
// If fn returns true, ScanOne immediately stops and returns ErrorCodeCallback.
//
// ... |
Author
|
Any updates? |
romshark
requested changes
Dec 18, 2023
|
|
||
| // ReadNumber returns the index of the end of the number value | ||
| // and err=true if a syntax error was encountered. | ||
| func ReadNumber[S ~string | ~[]byte](s S) (trailing S, err bool) { |
Owner
There was a problem hiding this comment.
This boolean actually indicates whether there was an error, please don't change it in internal/jsonnum
Co-authored-by: Roman Sharkov <roman.scharkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renamed walker closure's named return value to
exitinstead oferr, as considered in #21