This repository was archived by the owner on Aug 31, 2023. It is now read-only.
chore(ci): centos7 ci container#3866
Merged
Merged
Conversation
✅ Deploy Preview for docs-rometools canceled.
|
Contributor
|
Would you mind adding a description and test plan to your PR? |
ematipico
approved these changes
Nov 28, 2022
Comment on lines
+1
to
+4
| cd rome-ci-x86-64-centos7 | ||
| docker build . --tag rome-ci-x86-64-centos7:latest | ||
| docker push rome-ci-x86-64-centos7:latest | ||
| cd .. No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: should we move these files under a scripts/ folder instead?
Contributor
Author
There was a problem hiding this comment.
hum... I prefer to keep everything under ci at the moment. Because we will have other containers in the future.
MichaReiser
reviewed
Nov 30, 2022
MichaReiser
left a comment
MichaReiser
left a comment
Contributor
There was a problem hiding this comment.
Have you considered running the docker image directly without publishing it to docker hub first.
https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates the container need to build Rome using older glibc.
Will unblock #3650
Test Plan
Thus github action in this PR should publish a container to our container domain inside github;
And we should be able to build rome using this container on PR #3650
Rome binary should depend on glibc 2.17.
Rome binary should run on a standard container using CentOS.