Fix download.py to work without global variables#5
Open
meffmadd wants to merge 1 commit intorois-codh:masterfrom
Open
Fix download.py to work without global variables#5meffmadd wants to merge 1 commit intorois-codh:masterfrom
meffmadd wants to merge 1 commit intorois-codh:masterfrom
Conversation
Since Python 3.8 on the macOS version, the multiprocessing module does not use spawn anymore so global variables become unavailable (see: https://bugs.python.org/issue39931). With this change redownloading_warning becomes unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.8 on the macOS version the multiprocessing module does not use spawn anymore so global variables become unavailable in Pools (see: https://bugs.python.org/issue39931). I simply pass all necessary variables as arguments instead. With this change redownloading_warning becomes unavailable.
Fixes #4